grid and table properties practice: Fix misplaced greater than symbol in code sample #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
changed the title
mcking65
added
editorial
mcking65
added this to the 2025-02 February 2025 APG publication pull requests milestone
adampage
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you for catching this, @maeldebon!
During the review, I’ve discovered another occurrence of the same issue at lines 239–240. Could we trouble you to fix that one as part of this PR as well? cc: @mcking65
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: PR 3194 - Grid and table properties practice editorial fix<jugglinmike> github: https://github.com//pull/3194 <jugglinmike> Matt_King: The change in this pull request seems good <jugglinmike> Matt_King: Adam noted that the problem exists elsewhere <jugglinmike> Matt_King: It seems editorial because it's a misplaced ">" in the code example (not in executable code) <jugglinmike> Matt_King: Adam said the change here is good. He asked the person who wrote the PR if they could fix it in the other place where the problem occurs <jugglinmike> Matt_King: It's been over a week, though, so I'm wondering if anyone here would like to push the fix <jugglinmike> howard-e: I can help out, though I notice that this patch is the author's first contribution to the project. It might be nice to give them a little more time <jugglinmike> Matt_King: You're right, there's no rush here. Though if we push to their branch, they will still be recognized as a contributor <jugglinmike> Matt_King: If the original contributor provides that fix before February 11th, great. If not, we'll have howard-e or someone else lend a hand on their branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.